ADR shouldn't work for ClassA nodes activated with OTAA

ChirpStack Network Server
1

Hi dear brocaar. I’m trying to test ADR for OTAA, But I saw the source code of loraser/adr.go.
https://forum.loraserver.io/uploads/default/original/1X/32811bed20e6a04729008c7540f8e596a8fa843f.png

ns.ADRIntervarl should be set 0 when the node re-activated with OTAA, so there will return nil, is that?

I add log output for log node’s default arguments when the node re-activated with OTAA,

there is nothing to do for ADR
there is nothing to do for ADR.png868×187 6.4 KB

log node's default arguments with re-activied
log node's default arguments with re-activied.png855×489 16 KB

then we can see the logs, when nodes re-activated with OTAA.

入网请求时，AS给定的初始值信息 AdrInterval=0 DisableFCntCheck=false InstallationMargin=0 NwkSKey=[110 80 35 204 40 233 200 244 137 250 131 175 121 88 227 33] Rx1DROffset=0 Rx2DR=0 RxDelay=0 RxWindow=RX1

WARN[0013] there is nothing to do for ADR fullFCnt=0 macPL.FHDR.FCtrl.ADR=true ns.ADRInterval=0

this is full logs Screenshots

full logs
full logs.png1920×1080 220 KB

2

Please update to the latest version :slight_smile: It includes some changes to ADR and this code is not present anymore.

https://forum.loraserver.io/t/release-lora-server-0-22-0-lora-app-server-0-14-x-read-carefully/350

3

Okay, i will soon update to the latest version. Thanks :slightly_smiling_face: