Deleting a device profile on Chirpstack 4 deletes the devices that use it

Toneser · January 4, 2024, 10:17am

Hello,

Context:

Working on a ChirpStack v4.5.1
Configuration has been migrated from a ChirpStack v3 with the official migration tool
We have had no issues in months of operation

Issue:

A device profile used by several devices was misconfigured. A developer took the decision to delete it to create it from scratch. After deleting the misconfigured device profile, all devices that used it were removed from the database.

We have been able to replicate on the same environment this behavior with a test device profile and test devices.

My question here is if this behavior is a bug or is there a setting that our team has done wrong. We would expect to either be denied when requesting an action that will delete devices from ChirpStack as a secondary effect or at least be notified of the consequences of deleting a device profile in usage before this action can be taken.

Thank you

bconway · January 4, 2024, 3:39pm

This is by design:

github.com

chirpstack/chirpstack/blob/9f67b9c221e4971feadbcad32514a1419d5b5b0f/chirpstack/migrations/00000000000000_initial/up.sql#L189


      
          );
          
          create index idx_device_profile_tenant_id on device_profile (tenant_id);
          create index idx_device_profile_name_trgm on device_profile using gin (name gin_trgm_ops);
          create index idx_device_profile_tags on device_profile using gin (tags);
          
          -- device
          create table device (
              dev_eui bytea primary key,
              application_id uuid not null references application on delete cascade,
              device_profile_id uuid not null references device_profile on delete cascade,
              created_at timestamp with time zone not null,
              updated_at timestamp with time zone not null,
              last_seen_at timestamp with time zone,
              scheduler_run_after timestamp with time zone null,
              name varchar(100) not null,
              description text not null,
              external_power_source boolean not null,
              battery_level numeric(5, 2),
              margin int,
              dr smallint,

One could definitely argue whether this is the best design, though. One might be inclined to not allow non-empty applications or device profiles to be deleted.

Toneser · January 8, 2024, 8:08am

Thanks for the answer. I should have checked the git for this before asking. We would argue that this might not be the best design. Having several devices deleted without warning might not be optimal.

Thank you again. I am marking this as solved.

brocaar · January 9, 2024, 3:18pm

Maybe we could update the delete popup? I’m happy to review a pull-request for this.

sagarpatel · January 10, 2024, 5:03am

@brocaar

Yes, we can update the delete popup with the proper message.

datnus · January 16, 2024, 3:42pm

I suggest only allowing to delete a device profile if no device uses that device profile.

system · April 15, 2024, 3:43pm

This topic was automatically closed 90 days after the last reply. New replies are no longer allowed.